Skip to content
This repository was archived by the owner on Jul 7, 2021. It is now read-only.

Fix warnings in test code #361

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix warnings in test code #361

wants to merge 7 commits into from

Conversation

@ccostin93
Copy link
Collaborator

@ccostin93 ccostin93 commented Nov 26, 2020 •
edited by proshin-roman
Loading

This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 28, 2020 •
edited
Loading

Codecov Report

Merging #361 (9b5b979) into master (823465b) will increase coverage by 0.49%.
The diff coverage is 78.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #361      +/-   ##
============================================
+ Coverage     83.94%   84.43%   +0.49%     
- Complexity     1043     1050       +7     
============================================
  Files           176      177       +1     
  Lines          2572     2557      -15     
  Branches         20       16       -4     
============================================
  Hits           2159     2159              
+ Misses          395      385      -10     
+ Partials         18       13       -5
Impacted Files Coverage Δ Complexity Δ
...finapi/bankconnection/out/FpTwoStepProcedures.java 100.00% <ø> (ø) 7.00 <0.00> (ø)
...n/java/org/proshin/finapi/mandator/FpMandator.java 92.00% <ø> (ø) 9.00 <0.00> (ø)
.../org/proshin/finapi/exception/FinapiException.java 50.00% <66.66%> (ø) 9.00 <1.00> (ø)
...n/java/org/proshin/finapi/endpoint/FpEndpoint.java 78.12% <79.31%> (+11.45%) 15.00 <8.00> (+3.00)
...inapi/exception/FinapiAuthenticationException.java 80.00% <80.00%> (ø) 3.00 <3.00> (?)
...n/java/org/proshin/finapi/mock/in/Transaction.java 100.00% <0.00%> (+6.25%) 12.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f780c...9b5b979. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ccostin93 ccostin93 mentioned this pull request Feb 26, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@proshin-roman proshin-roman Awaiting requested review from proshin-roman

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ccostin93